Indicia-Team / ecobat

Repository for Ecobat specific code.
GNU General Public License v3.0
0 stars 0 forks source link

Adding multiple locations within 1 datasheet #7

Closed PaulLintott closed 8 years ago

PaulLintott commented 8 years ago

We've just been experimenting with uploading data from multiple sites within 1 spreadsheet. When we come to analyse that dataset we only end up with an output from the top location? Are we able to provide multiple outputs for multiple locations or are we better off asking for each location to be uploaded separately?

johnvanbreda commented 8 years ago

The output does include the entire import not just 1 location, but it uses the averaged x, y coordinate to determine a centre point from which to calculate the reference range. What worries me slightly about splitting out multiple locations is that might make the user think there are multiple reference ranges being used, but that would of course impact performance. So I think we could do something about splitting out locations but need to think it through carefully and make sure that performance is not impacted.

PaulLintott commented 8 years ago

Ok - this makes sense and it might be something we just need to make clearer in our description of Ecobat. However, the situations we need to be aware of are as follows:

So the options I can imagine are:

johnvanbreda commented 8 years ago

Hi Paul I'd suggest the following: 1) For the initial release, we keep it as it is and add a note somewhere about separating location uploads if they need separate analysis. 2) Add to the list of requirements for v1.1 - a tick box allowing analysis to be split by location or lumped as it is now. 3) Another requirement for v1.1 - a tick box on the list of imports that allows you to subdivide these by location and pick a specific one to analyse.

Either way we'd need to agree on what constitutes a different location - e.g. is it anything with a different easting or northing? You might also want to split by detector when (as in the example import) the x,y coords are the same for several detectors because they don't have a precise coordinate for each.

PaulLintott commented 8 years ago

Happy to go with this - we'll flag it up in the step by step guide..