Indicia-Team / warehouse

GNU General Public License v3.0
5 stars 3 forks source link

UK Mater List updates not propagated to verification rules and other species lists #414

Open JimBacon opened 2 years ago

JimBacon commented 2 years ago

If there is a name change for a taxon in the UK Master List, resulting in a new preferred TVK (external_key), then auto-verification runs in to problems.

For records made against the UK Master List

For records made against a different species list Other species lists are not updated with the changes made to the UK Master List so a taxon with a name change in the master list will still have the old TVK as external_key in other lists.

JimBacon commented 2 years ago

Hi @johnvanbreda, do you have any thoughts, for or against,

  1. Updating the TVK of verification rules on changes to preferred TVKs in the master list,
  2. Updating the external_key of taxa in other lists when a preferred TVK changes in the master list?

The aspiration would be for verification rules and auto acceptance to continue functioning after changes to the master list.

johnvanbreda commented 2 years ago

@JimBacon I agree with these suggestions and I do something similar for associated taxa in the Pantheon project. In the longer term, the organism_key provides a more robust way of defining a single taxonomic concept that doesn't change quite as frequently as the accepted name TVK. This option wasn't available when these tables were designed but would be the way to go now.