Indicio-tech / pydid

Python library for validating, constructing, and representing DIDs and DID Documents
Apache License 2.0
11 stars 12 forks source link

DIDCommService type literal string is inconsistent with peer-did service spec #63

Open Jsyro opened 1 year ago

Jsyro commented 1 year ago

I'm not sure if this is a legitimate issue, or if this will cause any errors in the future, however I have observed that the literal string in the DIDCommService class here is not the same expected string expected by the peer did spec here (see common abbreviations table just above example 3).

https://identity.foundation/peer-did-method-spec/#multi-key-creation

I have not seen any errors, but imagine it could if there was code that was only looking for the abbreviated dm value.