NER versioning update - Githubissues

IndicoDataSolutions / IndicoIo-node

A Node.js wrapper for the Indico API

MIT License

62 stars 7 forks source link

NER versioning update #113

Closed anneCarlson closed 8 years ago

anneCarlson commented 8 years ago

Reviewers:

[x] @madisonmay
[ ] @anneCarlson
What's the purpose of the PR?

Updates version number of ner. https://trello.com/c/voWeqH80/1986-3-ner-updated-in-client-libs-default-version

Description of changes

Notes to reviewers

Keep in mind while reviewing code:

Is relevant code tested?
Are added functions/methods documented?
Separation of concerns (SOC)
Don't repeat yourself (DRY)
Limit the number of positional arguments
Is function/method length reasonable?
Can code be broken down into smaller components?
Where do added functions/methods belong?
Are variable names descriptive?
Are errors handled appropriately?
Can logic be simplified?
Does the code make sense in context? (expand the diff)

sihrc commented 8 years ago

version 1 tests?

madisonmay commented 8 years ago

LGTM