issues
search
IndicoDataSolutions
/
IndicoIo-node
A Node.js wrapper for the Indico API
MIT License
62
stars
7
forks
source link
NER versioning update
#114
Closed
madisonmay
closed
8 years ago
madisonmay
commented
8 years ago
Reviewers:
[ ] @mention
What's the purpose of the PR?
Description of changes
Notes to reviewers
Keep in mind while reviewing code:
Is relevant code tested?
Are added functions/methods documented?
Separation of concerns (SOC)
Don't repeat yourself (DRY)
Limit the number of positional arguments
Is function/method length reasonable?
Can code be broken down into smaller components?
Where do added functions/methods belong?
Are variable names descriptive?
Are errors handled appropriately?
Can logic be simplified?
Does the code make sense in context? (expand the diff)
Reviewers:
What's the purpose of the PR?
Description of changes
Notes to reviewers
Keep in mind while reviewing code: