WIP: Custom collections permissioning support - Githubissues

IndicoDataSolutions / IndicoIo-ruby

A simple Ruby Wrapper for the indico set of APIs

MIT License

13 stars 2 forks source link

WIP: Custom collections permissioning support #103

Closed madisonmay closed 8 years ago

madisonmay commented 8 years ago

Reviewers:

[x] @madisonmay
[x] @anneCarlson
[x] @sihrc
What's the purpose of the PR?

Description of changes

Notes to reviewers

Keep in mind while reviewing code:

Is relevant code tested?
Are added functions/methods documented?
Separation of concerns (SOC)
Don't repeat yourself (DRY)
Limit the number of positional arguments
Is function/method length reasonable?
Can code be broken down into smaller components?
Where do added functions/methods belong?
Are variable names descriptive?
Are errors handled appropriately?
Can logic be simplified?
Does the code make sense in context? (expand the diff)