Indigo744 / Modx-Revo-Simple-Ace-Code-Editor

Ace (Ajax.org Cloud9 Editor) *simple* integration for MODx Revolution.
GNU General Public License v3.0
8 stars 2 forks source link

Update readme.md #15

Closed mindeffects closed 5 years ago

mindeffects commented 5 years ago

Mixing HTML and MODX-tags in a chunk sometimes causes highlighting errors marked with an [X]. Using text/plain solves that for mixed code and general purpose.

Listing the MIME types is more readable.

Indigo744 commented 5 years ago

While I appreciate the PR regarding the listing which doesn't look good (I botched the markup somehow), I fail to understand the part about text/plain for chunks.

For chunks, default syntax highlighting is HTML. But if the file is static, syntax highlighting is taken from the extension. It can be overridden with MIME type in description or comment. That's all.

Also, you should not have issue with MODX tag, as it should be recognized (unless in PHP mode). If that is the case, please open an issue with an example and I'll look into it.

mindeffects commented 5 years ago

TV with text/html: image

TV with text/plain: image

Indigo744 commented 5 years ago

Can you open a proper issue regarding multiline Modx tag with HTML mode? Thanks.

I'll close this PR and we'll look into this issue.