search

Indigo744 / Modx-Revo-Simple-Ace-Code-Editor

Ace (Ajax.org Cloud9 Editor) *simple* integration for MODx Revolution.
GNU General Public License v3.0
8 stars 2 forks source link

Syntax Highlighting Issues? #6

Closed kolbykruger closed 6 years ago

kolbykruger commented 6 years ago

I have some interesting discrepancies in the highlighting in MODX vs the Ace Editor highlight demo.

For instance, using the flex property for CSS: justify-content: center; in MODX it does not syntax highlight for justify-content, although in the Ace Editor demo seen here: (https://ace.c9.io/build/kitchen-sink.html) it highlights perfectly.

Could this be something to do with the custom MODX highlighting in modx_highlight_rules.js? It happens with the old Ace extra as well, and it seems the only similarities are that file pulled from that project.

Indigo744 commented 6 years ago

Indeed, I can reproduce it with justify-content: center;. I'll look into it asap :smile:

Indigo744 commented 6 years ago

Well, actually it does work:

in CSS:

image

in HTML:

image

However, it doesn't work in SASS: image

Which is the same as Ace (try in the kitchen sink)

Indigo744 commented 6 years ago

The flex-flow property suffers from the same issue in SASS/SCSS. They are, however, properly highlighted in LESS.

Indigo744 commented 6 years ago

@c0mat0se I think the proper step would be to open a ticket in the Ace repo https://github.com/ajaxorg/ace/issues regarding SASS highlighting issues.

kolbykruger commented 6 years ago

Will do. Thanks man!