search

IndigoDomotics / indigo-pushover

Indigo plugin to send push notifications via Pushover.
MIT License
17 stars 11 forks source link

1.5.2 is broken #25

Closed dawiinci closed 5 years ago

dawiinci commented 5 years ago 
   Pushover Error                  Error in plugin execution InitializeMain:

Traceback (most recent call last):
IndentationError: ('expected an indented block', ('plugin.py', 120, 10, '    \t\tself.debugLog(u"Result: %s" % r.text)\n'))

Thanks for the quick fix for 1.5.1, but it fails to load completely.

FlyingDiver commented 5 years ago

Please test https://github.com/IndigoDomotics/indigo-pushover/releases/tag/1.5.3

FlyingDiver commented 5 years ago

I don't actually have Pushover set up so I can't test these...

jcs commented 5 years ago

If you don't use Pushover, maybe let others maintain this driver? The past few changes were merged and pushed out before I even had a chance to review them.

FlyingDiver commented 5 years ago

Yeah, I jumped the gun on this last fix. Sorry about that.

dawiinci commented 5 years ago

Thank you though, it works now.

FlyingDiver commented 5 years ago

Good. I'll let @jcs look it over in case there's anything else needs to be fixed before it gets pushed.

jcs commented 5 years ago

I would like to fix #26 but I think that is an upstream issue, so the 1.5.3 changes look ok to me.