search

IndigoDomotics / indigo-pushover

Indigo plugin to send push notifications via Pushover.
MIT License
17 stars 11 forks source link

Add support for entering a custom sound name #31

Closed jcs closed 3 years ago

jcs commented 3 years ago

Pushover supports custom sounds now, so add an additional field to enter a custom-uploaded sound name. This seems like the easiest way of integrating that without having to parse the sounds API and cache the user's custom sound names.

This also bumps the version to 1.6.1.

FlyingDiver commented 3 years ago

I don't even see anything in the API that allows to retrieve the custom sounds, do you? The API says that the list of sounds should be downloaded rather than hard-coded, which the plugin doesn't do.

jcs commented 3 years ago

You can fetch them from https://api.pushover.net/1/sounds.json?token=(api token here). Any custom sounds are put at the beginning of the list.

FlyingDiver commented 3 years ago

Hmmm. Maybe kill two birds with one stone and fetch the list instead of hard coding it?

jcs commented 3 years ago

Sure, feel free to implement that :)

FlyingDiver commented 3 years ago

I'll take a look.

FlyingDiver commented 3 years ago

Added issue #32 for this.

Please try the most recent commit.