RX-V3900 TypeError on Set Input Action

ccons commented 6 years ago

I added an RX-V3900 device. When I attempt to add action type Set Input, the drop-down list in the Configure Set Input pop-up is not populated (- select and item -), and the following appears in the Event Log. Any ideas?

Yamaha RX Receiver Error Error in plugin execution GetUiDynamicList:

Traceback (most recent call last): TypeError: Expecting an object of type list; got an object of type tuple instead

ccons commented 6 years ago

I replaced <List class="self" method="get_input_list" dynamicReload="true" /> in Actions.xml with the from from Devices.xml > Devices.receiver.States.input, and the action now works as expected. I'm guessing this would break the newer receivers though.

ccons commented 6 years ago

OK, I'd submit the patch myself, but I've never done that on GitHub. These are the changes to fix in plugin.py:

Replace lines 36-53 with kInputList = [ "SIRIUS", "XM", "TUNER", "MULTI CH", "PHONO", "CD", "TV", "MD/CD-R", "BD/HD DVD", "DVD", "CBL/SAT", "DVR", "VCR", "V-AUX", "DOCK", "PC/MCX", "NET RADIO", "Rhapsody", "SIRIUS InternetRadio", "USB" ]. That is, return a list instead of a tuple.
Replace line 450 with val = pluginAction.props['ddlinput'].replace(".","/").replace("_"," "). That is, don't modify case.

plugin.py.txt

IndigoDomotics / indigo-yamaharx

RX-V3900 TypeError on Set Input Action #13