IndivisibleSomerville / its-our-call

2 stars 1 forks source link

Open andrewtremblay opened 6 years ago

andrewtremblay commented 6 years ago

Add a 404 page for users that mistype a url or otherwise poke around too much.

Requirements

[x] add a basic page MissingPage404 to /pages describing that the page does not exist
[x] add a <Route path='*' exact={true} component={MissingPage404} /> to App

A mock up might be added later to give more specific guides of what the 404 page looks like, otherwise; just have fun with it.

thekevinscott commented 6 years ago

Code branch open (https://github.com/IndivisibleSomerville/its-our-call/tree/kevin/404) and when designs are uploaded to Invision, I'll update the branch and open a PR.

Questions/comments:

Do we have integration tests? If so, should I add one for a 404 page?
I believe in a <Switch /> we can get away with just <Route component={pages.MissingPage404} /> but correct me if wrong
How do we feel about flexbox in CSS?
I ran into a type issue out of the gate and a parseInt missing radix error. I've fixed those in the branch but if there's some other way around those errors let me know.

andrewtremblay commented 6 years ago

@thekevinscott Good questions!

Integration tests would be great. I was holding off on adding them until the responsive design was finalized (and the API was visibly there) but feel free to add as many tests of as many types as you want.
You are correct for react router v4 (the path wildcard was needed for 1-3), feel free to take it out if you don't want it.
Quite a few bugs in flexbox (see https://github.com/philipwalton/flexbugs) I'd prefer not to use it but can be convinced otherwise.
A type issue in the master branch?! Yeah, file a bug please (even if your branch fixes it). Though I think it might be a linter problem.