Legislator Badge

[andrewtremblay]

/src/components/LegislatorBadge has a placeholder (🔵/🔴/⚪️emojis) to represent legislator party, this does not match current designs.

Requirements

• [x] Get/create white svgs for each state ~(see if design has assets for this)~
• [x] Change the emojis to a real circle and add state svgs ~as an optional property~.
• [x] ~Support more than two colors (Green party is a good edge-case)~

[fleenshop]

Re this one: "Support more than two colors (Green party is a good edge-case)" -- I don't think we need this. We group Independents in with the party they tend to caucus with. This has been fine when we've asked about it in user testing. Any reason that wouldn't apply equally to the Green party?

[andrewtremblay]

As long as we can easily infer party association through the data somewhere(e.g. green or democrat are always blue, republicans or tea party are always red), I'm totally fine with keeping it two colors.

I'd like to avoid hard-coding more complicated exceptions (e.g. any Independent party in Massachusetts not named 'tea party' = blue... etc.), as it makes code maintenance a real headache.

[fleenshop]

I think that sounds fine... If at some point, there's an Independent who tends to vote Republican, would we still be able to go in and set that person's color to red?

[andrewtremblay]

I'll let @NCPtarmigan handle that question. Guessing the inferred party of each individual Independent sounds out of scope for just the frontend, (and it sounds like pertinent data that the backend would want to keep track of as well).

At the very least I think frontend would need an additional field for inferredParty, or displayColorType.

[andrewtremblay]

I found a svg module for us states: https://coryetzkorn.github.io/state-svg-defs/ @rlmayfield if you think these are okay to use for the badge we can unblock this issue.

[rlmayfield]

@andrewtremblay those look good to me!

[andrewtremblay]