search

IndivisibleSomerville / its-our-call

2 stars 1 forks source link

Kevin/404 #64

Closed thekevinscott closed 2 years ago

thekevinscott commented 6 years ago

Questions/comments:

How much fidelity are we looking for in the translation from Invision to code? For instance, I notice the headers differ between the App and Invision, and the font weights specified don't seem to be there (looks like it's just normal and bold):

In code:

screen shot 2018-07-23 at 19 59 52

In Invision:

screen shot 2018-07-23 at 20 00 47
thekevinscott commented 6 years ago

I've updated this PR to not rely on flexbox.

I'm not sure the best way to get true vertical centering without it and would love input. It looks like the parent containers are not set to 100%, so I hard coded a margin on the h1 that works reasonably well for iphone 6/7/8 in Chrome. But it won't always be centered for every layout, let alone tablet/desktop.

Thoughts?

andrewtremblay commented 6 years ago

@thekevinscott Unless Becca told you otherwise I don't think we need true vertical centering here, just adequate margins to display the 404 in a generally central place. As for non-flexbox solutions: transform: translateY(-50%); gets you most of the way towards vertical centering (though mileage may vary).

As for adhering to the designs, I've kept it close as possible but it doesn't have to be religiously followed. For example, new font weights, (when found), should be added, but pixel perfection should be a low priority. A final evaluation before it goes live will probably be done by Stacy and/or Becca, that's when the pixels can be pushed around.

thekevinscott commented 6 years ago

My apologies for taking so long to address these comments!