search

IndivisibleSomerville / its-our-call

2 stars 1 forks source link

Various type linting issues on master #66

Open thekevinscott opened 6 years ago

thekevinscott commented 6 years ago

On pulling master and running yarn start I get:

Failed to compile.

/www/indivisible/its-our-call/frontend/its-our-call/src/@types/react-tiny-popover/index.d.ts
(57,26): Namespace 'React' has no exported member 'CSSWideKeyword'.

Once that's fixed, there's a couple of radix bugs on lines 135, 136, and 137 of pages/IssueView:

Failed to compile.

/www/indivisible/its-our-call/frontend/its-our-call/src/pages/IssueView.tsx
(135,42): Missing radix parameter

It looks like tslint defines radix as true, and I'm not sure which rules catches the missing exported member but both errors prevent the app for loading from me.

These are fixed in #65

andrewtremblay commented 6 years ago

We might have to pin our versions a bit harder, that first exported member error could be due to a version mismatch: (Similar to: https://github.com/OfficeDev/office-ui-fabric-react/issues/3603)

Also these errors could have occurred because I haven't been using yarn start, but rather npm start.