Closes #35 | Create dataset loader for IndoNLU NERGrit

cahya-wirawan commented 1 year ago

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script nusantara/nusa_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _NUSANTARA_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one NusantaraConfig for the source schema and one for a nusantara schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

christianwbsn commented 1 year ago

/test dataset=nergrit

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3059521401

cahya-wirawan commented 1 year ago

Hi @bryanwilie, thanks for approving this PR. However, @SamuelCahyawijaya and I agreed to change the name of the dataset to "IndonNLU Nergrit" (update will follow soon) because we have another NERGrit dataset https://github.com/IndoNLP/nusa-crowd/issues/270 (the dataset is different and contains 3 subset datasets) where I will also create its dataloader.

SamuelCahyawijaya commented 1 year ago

Hi Pak @cahya-wirawan, thank you for the update!

Due to a recent update in the master branch, we move all the source code from nusantara/ to nnusa_crowd/, would you help to merge with the master branch and move the dataset to the new folder?

On the other hand, is this PR ready to be reviewed?

cahya-wirawan commented 1 year ago

Ok, I will move to the new folder, and update the citation and License if it's necessary

SamuelCahyawijaya commented 1 year ago

/test dataset=indonlu_nergrit

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3160703619

IndoNLP / nusa-crowd