Closed IvanHalimP closed 1 year ago
/test dataset=id_hsd_nofaaulia subset_id=id_hsd_nofaaulia
Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3074073709
/test dataset=id_hsd_nofaaulia subset_id=id_hsd_nofaaulia
Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3076349967
I clicked the wrong button, sorry for that.
There's a request change. Please refer to the comment.
Thank you!
Btw @bryanwilie, I've checked about this one. In short, it is no problem. Please refer to the comment for more details.
We still need to add sklearn
to the requirements.txt
@holylovenia , but I guess we can also do it separately too.
Uhm, regarding this one I noticed that the '\n' is not removed yet. Do I need to clean it?
@IvanHalimP That would be nice! Just make a separate PR for that. I can help review it once you're done. Also, regarding @bryanwilie's suggestion to add sklearn
to the requirements, could you you help provide the version of sklearn
that you're using as well, @IvanHalimP?
@IvanHalimP That would be nice! Just make a separate PR for that. I can help review it once you're done. Also, regarding @bryanwilie's suggestion to add
sklearn
to the requirements, could you you help provide the version ofsklearn
that you're using as well, @IvanHalimP?
Should I put the sklearn version directly into the requirements.txt?
Closes #225
Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.
Checkbox
nusantara/nusa_datasets/my_dataset/my_dataset.py
(please use only lowercase and underscore for dataset naming)._CITATION
,_DATASETNAME
,_DESCRIPTION
,_HOMEPAGE
,_LICENSE
,_URLs
,_SUPPORTED_TASKS
,_SOURCE_VERSION
, and_NUSANTARA_VERSION
variables._info()
,_split_generators()
and_generate_examples()
in dataloader script.BUILDER_CONFIGS
class attribute is a list with at least oneNusantaraConfig
for the source schema and one for a nusantara schema.datasets.load_dataset
function.python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py
.