Closes #225 | Create dataset loader for ID-HSD-Nofaaulia

IvanHalimP commented 1 year ago

Closes #225

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script nusantara/nusa_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _NUSANTARA_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one NusantaraConfig for the source schema and one for a nusantara schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

IvanHalimP commented 1 year ago

/test dataset=id_hsd_nofaaulia subset_id=id_hsd_nofaaulia

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3074073709

IvanHalimP commented 1 year ago

/test dataset=id_hsd_nofaaulia subset_id=id_hsd_nofaaulia

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3076349967

holylovenia commented 1 year ago

I clicked the wrong button, sorry for that.

There's a request change. Please refer to the comment.

Thank you!

Btw @bryanwilie, I've checked about this one. In short, it is no problem. Please refer to the comment for more details.

bryanwilie commented 1 year ago

We still need to add sklearn to the requirements.txt @holylovenia , but I guess we can also do it separately too.

IvanHalimP commented 1 year ago

Uhm, regarding this one I noticed that the '\n' is not removed yet. Do I need to clean it?

holylovenia commented 1 year ago

@IvanHalimP That would be nice! Just make a separate PR for that. I can help review it once you're done. Also, regarding @bryanwilie's suggestion to add sklearn to the requirements, could you you help provide the version of sklearn that you're using as well, @IvanHalimP?

IvanHalimP commented 1 year ago

@IvanHalimP That would be nice! Just make a separate PR for that. I can help review it once you're done. Also, regarding @bryanwilie's suggestion to add sklearn to the requirements, could you you help provide the version of sklearn that you're using as well, @IvanHalimP?

Should I put the sklearn version directly into the requirements.txt?

IndoNLP / nusa-crowd