Closes #276 | Create dataset loader for INDspeech_NEWSTRA_EthnicSR

IvanHalimP commented 1 year ago

Please name your PR after the issue it closes. You can use the following line: "Closes #ISSUE-NUMBER" where you replace the ISSUE-NUMBER with the one corresponding to your dataset.

Closes #276

Checkbox

[x] Confirm that this PR is linked to the dataset issue.
[x] Create the dataloader script nusantara/nusa_datasets/my_dataset/my_dataset.py (please use only lowercase and underscore for dataset naming).
[x] Provide values for the _CITATION, _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _NUSANTARA_VERSION variables.
[x] Implement _info(), _split_generators() and _generate_examples() in dataloader script.
[x] Make sure that the BUILDER_CONFIGS class attribute is a list with at least one NusantaraConfig for the source schema and one for a nusantara schema.
[x] Confirm dataloader script works with datasets.load_dataset function.
[x] Confirm that your dataloader script passes the test suite run with python -m tests.test_nusantara --path=nusantara/nusa_datasets/my_dataset/my_dataset.py.
[ ] If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

I have several questions:

The repo has 2 datasets. Which one should I use? This initial PR uses only 'dataset1' as it is the closest to the description in the card
There are 4 languages (Batak, Bali, Sunda, and Jawa), the language code I use is based on the abbreviation in the dataset. Is that acceptable or should I follow a certain standard?
Regarding the train/test split, the card mentions that there are 9000/4000 samples. I do think that it refers to all the languages combined excluding 'dataset2'.
The dataset2 has another 1600/50 samples per language. However, if I include them into the loader, it won't match the description in the card.

That's all my concerns so far. Looking forward for any guide. Thanks in advance.

IvanHalimP commented 1 year ago

/test dataset=indspeech_newstra_ethnicsr subset_id=indspeech_newstra_ethnicsr_Jaw

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3118214419

IvanHalimP commented 1 year ago

/test dataset=indspeech_newstra_ethnicsr subset_id=indspeech_newstra_ethnicsr_jaw

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3163659870

IvanHalimP commented 1 year ago

/test dataset=indspeech_newstra_ethnicsr subset_id=indspeech_newstra_ethnicsr_jaw

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3163683151

IvanHalimP commented 1 year ago

oh wait. I just saw @SamuelCahyawijaya's reply on slack... Will upd tmr.

IvanHalimP commented 1 year ago

/test dataset=indspeech_newstra_ethnicsr subset_id=indspeech_newstra_ethnicsr_overlap_btk

IvanHalimP commented 1 year ago

/test dataset=indspeech_newstra_ethnicsr subset_id=indspeech_newstra_ethnicsr_nooverlap_sun

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3167213062

github-actions[bot] commented 1 year ago

Run result

Check test log here: https://github.com/IndoNLP/nusa-crowd/actions/runs/3167212587

IndoNLP / nusa-crowd