Send raw note data - [merged]

[Indomet]

In GitLab by @mohamadk on May 14, 2023, 19:29

Merges send-raw-note-data -> main

Requirement

As a user, I want the Arduino to receive notes that could be played when I press a song on the app

[Related to: #42] [Closes #47]

Acceptance criteria

• [x] passes all tests
• [x] data must be transferrable via mqtt
• [x] data must be parsable by arduino

[Indomet]

In GitLab by @mohamadk on May 14, 2023, 19:29

requested review from @almuslim

[Indomet]

In GitLab by @almuslim on May 14, 2023, 20:54

Commented on NoteParser/src/main/java/com/wioplay/parser/Core/Parser.java line 69

Good change to convert it to private over static. Increases encapsulation and hides implementation details well done

[Indomet]

In GitLab by @almuslim on May 14, 2023, 20:55

Commented on NoteParser/src/main/java/com/wioplay/parser/Network/Subscriptions/getSongs.java line 29

I would try to add a handling case in case an exception gets caught here

[Indomet]

In GitLab by @almuslim on May 14, 2023, 20:55

approved this merge request

[Indomet]

In GitLab by @almuslim on May 14, 2023, 20:56

Code looks good to me. Good stuff

[Indomet]

In GitLab by @mohamadk on May 14, 2023, 22:05

mentioned in commit d0218be7c939a5dfea6638c340dbd211c323bd98