Indomet / WioPlay

1 stars 1 forks source link

Music slowdown during burndown chart update and transition - [merged] #125

Closed Indomet closed 1 year ago

Indomet commented 1 year ago

In GitLab by @mehmetas on May 16, 2023, 21:00

Merges fix-music-delay-caused-by-burndownchart -> main

Which bug does this MR address?

Fixes #50 The bug was fixed by implementing a non-blocking delay. This means that the delay in the music playback during the update and transition to the burndown chart is now handled in a way that allows other processes to continue running concurrently without being blocked.

By using the non blocking delay, the music playback is no longer affected by the update and transition process, resulting in a smoother experience for the users.The merge request makes the delaying better but it is not perfect due to hardware limitations.

Related issues

[Related to #20 and #9]

Indomet commented 1 year ago

In GitLab by @mehmetas on May 16, 2023, 21:00

requested review from @almuslim

Indomet commented 1 year ago

In GitLab by @almuslim on May 16, 2023, 21:00

approved this merge request

Indomet commented 1 year ago

In GitLab by @almuslim on May 16, 2023, 21:01

Pulled to the branch locally and it works good job

Indomet commented 1 year ago

In GitLab by @almuslim on May 16, 2023, 21:01

mentioned in commit 447b6401dafc2f939d1483d09f247940ed102fc3