Improving the profile picture functionality - [merged]

[Indomet]

In GitLab by @jacniy on May 20, 2023, 09:42

Merges savePicture -> main

Refactoring

the picture needs still be in its designated place when the user reopens the app. ## Goals The goal is to have the same profile picture when the user reopens the app [Related to: #60 ] [Closes issue #60 ] ## Acceptance criteria - [x] add the picture to its designated place - [x] have the picture stay after the user reopens the app

[Indomet]

In GitLab by @jacniy on May 20, 2023, 09:42

requested review from @zepei

[Indomet]

In GitLab by @zepei on May 20, 2023, 10:14

Commented on AndroidApp/app/src/main/java/com/example/myapplication/MusicFragment.java line 149

Good use of File.separator here to make sure the syntax is applicable for all devices.

[Indomet]

In GitLab by @zepei on May 20, 2023, 10:16

Commented on AndroidApp/app/src/main/java/com/example/myapplication/MusicFragment.java line 154

Adding comments to these two lines of code would be helpful for other developers to understand why this is needed.

[Indomet]

In GitLab by @zepei on May 20, 2023, 10:44

Commented on AndroidApp/app/src/main/java/com/example/myapplication/MusicFragment.java line 170

Why is the profile picture functionality being handled in the MusicFragment class? Consider refactoring to Util or SettingsFragment for example as this as it violates the single responsibily principle.

[Indomet]

In GitLab by @mohamadk on May 21, 2023, 17:03

added 31 commits

• dbdbd2e0...887be293 - 30 commits from branch main
• e5bacb88 - merge with main

Compare with previous version

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:10

Commented on AndroidApp/app/src/main/java/com/example/myapplication/MusicFragment.java line 136

Delete commented method

[Indomet]

In GitLab by @mohamadk on May 21, 2023, 17:11

Commented on AndroidApp/app/src/main/java/com/example/myapplication/MusicFragment.java line 136

changed this line in version 3 of the diff

[Indomet]

In GitLab by @mohamadk on May 21, 2023, 17:11

added 1 commit

• 61356660 - remove redundant comments and attribute

Compare with previous version

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:13

approved this merge request

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:13

marked the checklist item add the picture to its designated place as completed

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:13

marked the checklist item have the picture stay after the user reopens the app as completed

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:15

All acceptance criteria passed

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:15

enabled an automatic merge when the pipeline for 61356660c41c76f36afcb8e7cf06529dbac193b9 succeeds

[Indomet]

In GitLab by @zepei on May 21, 2023, 17:16

mentioned in commit 7bbde4b2f0b7ba9fce4f9e9b91ff28b62adec794