IndrajeetPatil / statsExpressions

Tidy data frames and expressions with statistical summaries 📜
https://indrajeetpatil.github.io/statsExpressions/
Other
312 stars 20 forks source link

revdep issues with insight #179

Closed strengejacke closed 2 years ago

strengejacke commented 2 years ago

I get this error during revdep checks, is this expected?

Package: statsExpressions
Check: tests
New result: ERROR
    Running ‘spelling.R’ [0s/0s]
    Running ‘testthat.R’ [124s/124s]
  Running the tests in ‘tests/testthat.R’ failed.
  Complete output:
    > library(testthat)
    > library(dplyr)

    Attaching package: 'dplyr'

    The following object is masked from 'package:testthat':

        matches

    The following objects are masked from 'package:stats':

        filter, lag

    The following objects are masked from 'package:base':

        intersect, setdiff, setequal, union

    > library(statsExpressions)
    > 
    > test_check("statsExpressions")
    t is large; approximation invoked.
    Multiple `BFBayesFactor` models detected - posteriors are extracted from the first numerator model.
    See help("get_parameters", package = "insight").
    [ FAIL 1 | WARN 0 | SKIP 51 | PASS 34 ]

    ══ Skipped tests ═══════════════════════════════════════════════════════════════
    • On CRAN (51)

    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Error (test-tidy_model_expressions.R:47:3): tidy_model_expressions works - chi2 ──
    Error: Sorry, `model_parameters()` failed with the following error (possible
      class 'coxph.penal' not supported):

      Non-numeric argument to mathematical function
    Backtrace:
         ▆
      1. ├─base::suppressWarnings(...) at test-tidy_model_expressions.R:47:2
      2. │ └─base::withCallingHandlers(...)
      3. ├─statsExpressions::tidy_model_expressions(...)
      4. │ └─... %>% .data_to_char(k)
      5. ├─statsExpressions:::.data_to_char(., k)
      6. │ └─data %>% ...
      7. ├─dplyr::mutate(...)
      8. ├─dplyr::filter(...)
      9. ├─statsExpressions::tidy_model_parameters(mod_chi)
     10. │ ├─... %>% ...
     11. │ ├─parameters::model_parameters(model, verbose = FALSE, ...)
     12. │ └─parameters:::model_parameters.default(...)
     13. ├─dplyr::mutate(., across(matches("bf10"), ~log(.x), .names = "log_e_{.col}"))
     14. ├─tidyr::fill(., matches("^prior|^bf"), .direction = "updown")
     15. ├─dplyr::rename_all(., .funs = recode, bayes.factor = "bf10")
     16. │ └─dplyr::tbl_vars(.tbl)
     17. │   ├─dplyr:::new_sel_vars(tbl_vars_dispatch(x), group_vars(x))
     18. │   │ └─base::structure(...)
     19. │   └─dplyr:::tbl_vars_dispatch(x)
     20. ├─dplyr::rename_all(., ~gsub("cramers.", "", .x))
     21. │ └─dplyr::tbl_vars(.tbl)
     22. │   ├─dplyr:::new_sel_vars(tbl_vars_dispatch(x), group_vars(x))
     23. │   │ └─base::structure(...)
     24. │   └─dplyr:::tbl_vars_dispatch(x)
     25. ├─insight::standardize_names(., style = "broom")
     26. ├─dplyr::select(., where(~!all(is.na(.x))), -matches("Difference"))
     27. └─dplyr::mutate(., conf.method = . %@% "ci_method")

    [ FAIL 1 | WARN 0 | SKIP 51 | PASS 34 ]
    Error: Test failures
    Execution halted
IndrajeetPatil commented 2 years ago

No, this is not expected. This seems to be a bug either in insight or parameters.

Closing in favour of https://github.com/easystats/parameters/issues/776.