IndrajeetPatil / statsExpressions

Tidy data frames and expressions with statistical summaries 📜
https://indrajeetpatil.github.io/statsExpressions/
Other
311 stars 20 forks source link

_performance_ revdep-check issues #272

Closed strengejacke closed 4 months ago

strengejacke commented 4 months ago

I'm running revdep checks on performance, and following error was raised - however, I'm not sure if it's related to performance? Could you check?

> # ----------------------- parametric -----------------------
> 
> one_sample_test(mtcars, wt, test.value = 3)
Error in cohens_d(x = c(2.62, 2.875, 2.32, 3.215, 3.44, 3.46, 3.57, 3.19,  : 
  could not find function "cohens_d"
Calls: one_sample_test ... mutate -> exec -> <Anonymous> -> eval.parent -> eval -> eval
Execution halted
* checking for unstated dependencies in 'tests' ... OK
* checking tests ... [99s] ERROR
  Running 'testthat.R' [99s]
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
   1. ├─base::suppressWarnings(...) at test-two-sample-parametric.R:49:5
   2. │ └─base::withCallingHandlers(...)
   3. └─statsExpressions::two_sample_test(...)
  ── Error ('test-two-sample-parametric.R:91:5'): works with subject id ──────────
  Error in `cohens_d(x = c(82.5, 70, 67.5, 60, 72.5, 65, 97.5, 40, 82.5), 
      y = c(70, 92.5, 72.5, 90, 100, 95, 100, 92.5, 35), pooled_sd = FALSE, 
      paired = TRUE, ci = 0.95, alternative = "two.sided", verbose = FALSE, 
      adjust = TRUE)`: could not find function "cohens_d"
  Backtrace:
      ▆
   1. └─statsExpressions::two_sample_test(...) at test-two-sample-parametric.R:91:5

  [ FAIL 5 | WARN 0 | SKIP 49 | PASS 24 ]
  Error: Test failures
  Execution halted
IndrajeetPatil commented 4 months ago

Ah, yes, this is unrelated. I had already fixed the issue. I have submitted a new version to CRAN just now. Hopefully, it is accepted soon.

You can ignore this failure for performance update.

IndrajeetPatil commented 4 months ago

statsExpressions update is on CRAN.