IndustriaLeuven / Enrollments

0 stars 0 forks source link

Automatisch oude inschrijvingen toevoegen aan afzonderlijke lijst. #18

Open deraedemaeker opened 8 years ago

deraedemaeker commented 8 years ago

Er moeten 2 lijsten bestaan: "Open inschrijvingen" en "Oude inschrijvingen". Vanaf dat de eiddatum van een inschrijving is verstreken, moet de inschrijving naar de lijst "Oude inschrijvingen" worden verplaatst, zodat de open inschrijvingen standaad als eerste worden getoont in een afzonderlijke lijst.

kovankerckhoven commented 8 years ago

Should be resolved with https://github.com/IndustriaLeuven/Enrollments/pull/19 or after adjustments to that same pull request.

vierbergenlars commented 8 years ago

Isn't it sufficient to order by creation date? Forms that are created earlier typically also end sooner.

Because form start/end date is located in a "plugin", and may not always be present (and there are other ways to close a form to the public, like marking it internal or going over the maximum number of enrollments) it is impossible to properly know when a form can be considered "old".

The cleanest option I can think of is an extra boolean field on the Form entity that marks a form as archived. There would be a separate list of archived forms and a button to (un)archive a form. Optionally, an archived form can be coded to return a 404 not found or 410 gone when accessed on its public (non-admin) url. This option would be hard-coded and for all forms, to avoid having to show additional options when archiving a form.

Lars Vierbergen

On Jul 26, 2016 1:52 PM, "kovankerckhoven" notifications@github.com wrote:

Should be resolved with #19 https://github.com/IndustriaLeuven/Enrollments/pull/19 or after adjustments to that same pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/IndustriaLeuven/Enrollments/issues/18#issuecomment-235273978, or mute the thread https://github.com/notifications/unsubscribe-auth/ABI6mN2yoACmf2-v89aHB_n2olBBeH4Zks5qZhEsgaJpZM4JVDoN .

kovankerckhoven commented 8 years ago

Much quicker to be resolved with https://github.com/IndustriaLeuven/Enrollments/pull/19.