InetIntel / grip-ui

Other
0 stars 2 forks source link

Acknowledgements #10

Open albertodainotti opened 19 hours ago

albertodainotti commented 19 hours ago

Add acknowledgements to https://grip.inetintel.cc.gatech.edu/ack. At least GCA, Amazon, and Google

albertodainotti commented 19 hours ago
Tejas988 commented 17 hours ago

For adding acknowledgment to the MANRS project, prof has suggested adding two hyperlinks (manrs.org on clicking the logo and globalcyberalliance.org for "Global Cyber Alliance" in the description.

But as per the current code structure, we can't add multiple hyperlinks for a particular acknowledgment Card component. Any other way we could handle this or do I have to modify the component for this specific requirement? @salcock

salcock commented 16 hours ago

Yes, currently the link anchor applies to the entire card so you'll need to re-define the render() method to apply one link (perhaps defined as imagelink in the orgs list) to the image div and another link to the desc div.

If imagelink is not defined, then fall back to using the regular link instead for the image div so you don't have to duplicate the links for all of the existing orgs ;)

albertodainotti commented 6 hours ago

Hi all. We care more about timing than anything else. We can use just the MANRS link for that card for now.