search

InetIntel / ioda-ui

Other
3 stars 0 forks source link

Montana USA v Montana Bulgaria #90

Open amandahmeng opened 1 year ago

amandahmeng commented 1 year ago

I noticed this when logging an outage for AS13476 (MSU-BOZEMAN) which is registered to Montana, USA and is showing up in Montana Bulgaria

https://ioda.inetintel.cc.gatech.edu/asn/13476?from=1682000135&until=1682086535

salcock commented 1 year ago

Here's the most likely source of the problem: https://github.com/InetIntel/ioda-ui/blob/main/assets/js/Ioda/pages/entity/Entity.js#L1672

When we process the topo data to determine which region we should be highlighting, we look for the first region that has a name matching the name of the entity that is experiencing an outage.

If we have two regions of the same name (e.g. "Montana", USA and "Montana", Bulgaria) then this code will just pick whichever comes first in the topology list.

Instead, we should try to match on the id property which contains the region code and therefore should be a unique match to the region ID that is used by IODA within the FQID of an entity identifier.