Inevio / Gmail

0 stars 1 forks source link

no errors handling and revoked token actions #19

Closed icastillejogomez closed 6 years ago

icastillejogomez commented 6 years ago
  1. you have to handle all errors in app code.

  2. If "REVOKED USER TOKEN" is returned in error (all errors in app) you must show the oauth initial process pop-up bug4 bug3 bug2 bug1

burhan-project-manager commented 6 years ago

@jorge9200 there is a problem in listAccount API.

If we have more than 1 accounts and any ONE account has expired token then listAccount function is returning error of 401 in error argument.

Although other accounts are correct but it is returning null against account.

So ideally it should return error in each account. What do you think.

icastillejogomez commented 6 years ago

@burhan-project-manager okay, I'm going to make you an end-point to solve this.

jorge9200 commented 6 years ago

@icastillejogomez thank you so much, tell us when is done

icastillejogomez commented 6 years ago

You can call listDisableAccounts method on api.integration.gmail variable. In this screenshot and in your start.js file (static directory) you can find the example code.

gmail2

you can see the results:

gmail3

when i completed the oauth process:

gmail4

add the patch in this part too:

gmail2

thx!

burhan-project-manager commented 6 years ago

Thanks, it is implemented accordingly.