Inevio / Gmail

0 stars 1 forks source link

Search error #72

Closed josemhdez closed 6 years ago

josemhdez commented 6 years ago

When I search, the total ammount of emails after this search still has the same number as the total inbox. Furthermore, when I start going back to these first emails, at one point Im not able to continue searching for previous emails. image

burhan-project-manager commented 6 years ago

I understand first point but can you please explain following in little more details?

Furthermore, when I start going back to these first emails, at one point Im not able to continue searching for previous emails.

josemhdez commented 6 years ago

When there are no more emails which fit on the search I made, the arrow to go to older emails change to unclickable

burhan-project-manager commented 6 years ago

Ok i understand.

@icastillejogomez we have discussion about pagination in some older issue.

We were calling usersThreadsList to get total counts, but this API returns estimated count, so @icastillejogomez develop two other APIs usersGetProfile and usersLabelsGet to get actual count.

But in case of search we are not getting any count details. We need a way to get total accounts against searched query.

icastillejogomez commented 6 years ago

It's no possible. The only way to solve it is eliminate the "of X" text and wait to get the last page, then print "of X" text.

burhan-project-manager commented 6 years ago

We don't have total count in case of search so we can't calculate current page also.

But next/previous buttons will work fine.

Check now image

icastillejogomez commented 6 years ago

You have to print 1 - 20 ; 21 - 40 and when you get the last page then print in all pages

Before I get the last page:

1 - 20 21 - 40

After I get the last page:

1 - 20 of <total_messages_here> 21 - 40 of <total_messages_here>

burhan-project-manager commented 6 years ago

Pagination implemented in search.