Infamous-Misadventures / Dungeons-Gear

A mod that ports Minecraft Dungeons items to Minecraft
MIT License
49 stars 23 forks source link

When using the matrix enchanting system from quark, dungeons gear enchantments proc #266

Closed Gamershy closed 9 months ago

Gamershy commented 10 months ago

As the title says. If you enchant a weapon using matrix enchanting in Quark, the item will be able to be removed before the enchantments are finalized. This makes it to where the item stores the enchantments, so that you can continue building the weapon/tool/armor when you grind more levels. But, dungeons gear enchantments with special effects, such as Anima conduit, Rushdown, Freezing shot, etc, all still take effect even when the weapon isn't properly enchanted. Likely because the mod is simply checking for the weapon to have the necessary nbt data, rather than checking for it to properly have the enchantments. I'd say this is pretty vital to fix, as quark is immensely common in many modpacks, and any modpacks that choose to use matrix enchanting will be able to cheese the dungeons gear enchantments without locking in enchantments.

Gamershy commented 9 months ago

Uh... turns out I was wrong. Sorry. I was mistaking the effect of one of the modded weapons in my pack for the effect of Rampaging. MY bad entirely