search

Infamous-Misadventures / Dungeons-Gear

A mod that ports Minecraft Dungeons items to Minecraft
MIT License
49 stars 23 forks source link

SuperCharge enchant 0 damage level 4+ #269

Closed xThaySan closed 7 months ago

xThaySan commented 9 months ago 
src/main/java/com/infamous/dungeons_gear/enchantments/ranged/SuperchargeEnchantment.java

This part of the code makes the damage zero when the enchantment is level 4 or higher :

double damageModifier = 0;
if (superchargeLevel == 1) damageModifier = 1.2D;
if (superchargeLevel == 2) damageModifier = 1.4D;
if (superchargeLevel == 3) damageModifier = 1.6D;
arrow.setBaseDamage(originalDamage * damageModifier);

It may need to be modified to something like this:

double damageModifier = 1.0D + 0.2D * superchargeLevel;
arrow.setBaseDamage(originalDamage * damageModifier);
Thelnfamous1 commented 7 months ago

Duplicate of #264. Slated to be fixed for 1.19.2 only.