Infamous-Misadventures / Dungeons-Libraries

MIT License
6 stars 4 forks source link

Fatal error at random on latest 1.18.2 version #15

Closed Gotyam closed 1 year ago

Gotyam commented 1 year ago

Disclaimer: Using together with Dungeons Gear, and about 200 other mods, so cannot be certain if the error is caused by some form of incompatability making this mod throw an error, or if it is solely the dungeons mods.

The error is excatly as stated in the title, where I crash at random. Not Enough Crashes, and the log itself, states DungeonsLibraries as the cause of the fatal error. I have attached my latest log for you to look at and (try to) determine the cause. If you require more information or help with isolating the issue I am willing to assist!

Minecraft version: 1.18.2 Forge version: 40.1.92 Mod version(s): DungeonsLibraries 2.0.2, DungeonsGear 4.0.1

latest.log

Gotyam commented 1 year ago

For added help; my current gear from Dungeons Gear Equipped:

In inventory:

image_2022-12-28_131439156

Gotyam commented 1 year ago

All good things are three: Loaded up a backup from right after my first crash (loot still in chest). In the normal chest they still cause crash when hovered, but breaking the chest (as I first did because I am a loot goblin) puts them nicely in my inventory, where I can hover over them normally. Well, for a while. Had to restart once to get all the screenshots... And by restart I mean loading up the backup again, as when it has crashed once inside the inventory it seems to crash subsequent boots as well. And by all screenshots I mean the anchor seems to have not wanted to let me not crash since. I could see it before I decided to screenshot the items, but now, even after loading the backup again and doing things the exact same way, it does not want to work. image_2022-12-28_132915326 image_2022-12-28_132925641

Patrigan commented 1 year ago

I am so confused by this... There's clearly something wonky happening. I have a check at the beginning of that crashposition that checks if the thing is null, so it can't be null when it crashes. Literally impossible xD

I have moved the check to right before I use it. All I can think is that somewhere in between some other mods is causing the field to go empty. They'd be doing something weird, but finding that bug will be difficult.

So now you'll have to do with this xD

Patrigan commented 1 year ago

Probable fix coming in 2.0.3

Patrigan commented 1 year ago

Another attempt, I just released 2.0.4, which should fix this. I basically rewrote the whole code and the crashing field, enchantmentOnIteration, simply doesn't exist anymore.

Patrigan commented 1 year ago

I will close the issue now, as I'm fairly certain this is fixed.