Infamous-Misadventures / Dungeons-Libraries

MIT License
6 stars 4 forks source link

Immidiate Crash with OptiFine HD U I1 #33

Closed IAmSchilling closed 8 months ago

IAmSchilling commented 1 year ago

From version Dungeon Libraries 3.0.7 onwards game crashes immidiately on launch together with OptiFine HD U I1, lower versions do work just fine.

Forge Version 1.19.2 - 43.2.4 GeckoLib forge 1.19-3.1.39 Curios Forge 1.19.2-5.1.1.0

xenornithos commented 1 year ago

Same here. I wanted to be able to configure the artifacts key binds that conflict with other mods (using these newer Dungeons versions that should have the option), but OF HD U I1 causes an instant game crash, so I have to use the older versions of all of them (Dungeons Gear 5.0.2, Dungeons Libraries 3.0.6, and Dungeons Mobs 4.0.3 -- which at least will work with OF) without being able to fix the artifacts key binds issue.

Wubzzz1337 commented 1 year ago

Having the same issue :(

FantomTchi7 commented 1 year ago

Same here

AlexandersFunAndGames commented 1 year ago

OptiFine breaks a lot of mods and is not recommended to be used with mods, if you want shaders and better performance I recommend you use the mods Rubidium and Oculus

FantomTchi7 commented 1 year ago

OptiFine breaks a lot of mods and is not recommended to be used with mods, if you want shaders and better performance I recommend you use the mods Rubidium and Oculus

Oculus isn't updated on 1.19.2, once it gets an update, sure, but for now Optifine has better perfomance with shaders.

AlexandersFunAndGames commented 1 year ago

OptiFine was never made to run with mods and breaks most of them though, and these are problems that can't be fixed on the mods' ends

FantomTchi7 commented 1 year ago

I didn't say that I don't agree with you, howerer older versions of the mod do work properly, so it shouldn't be that hard to fix (might be completely wrong here though).

Patrigan commented 1 year ago

Anyone happen to have an actual crashlog for this?

xenornithos commented 1 year ago

Anyone happen to have an actual crashlog for this?

Just tested an instance with only the Dungeons mods and OF (Forge 43.1.52 (1.19.2), OptiFine HD U I1). It crashed in the launcher. This was the generated log file.

Patrigan commented 1 year ago

That is such a useless log file :( Not your fault, I just really hate how black box OptiNotFine is...

JAMalcolmson commented 1 year ago

OptiFine breaks a lot of mods and is not recommended to be used with mods, if you want shaders and better performance I recommend you use the mods Rubidium and Oculus

That's such a lame cop-out answer. Literally thousands of mods, some far more ambitious than this one, have 0 issues with any version of optifine, and then there's the odd one out like this and (until a week ago) NoCubes. For mods that are basically just adding normal objects and mobs, there's no explicable reason for it to malfunction in this way- especially when older versions of optifine don't crash it.

Also, saying "use Rubidium and Oculus" is the least helpful response. Neither of those offer even half of the graphical capabilities Optifine offers, which many resource packs depend on- not just shaders. Fresh Animations, Tooniverse, Xali's Vanilla, and Conquest, are all big name examples that need certain data optifine generates, that neither Oculus or Rubidium offer, whether you use shaders or not. There is a mod trying to add that data in, but it is currently very WIP, buggy, and mostly incompatible with other mods. Additionally, many shaders are optifine exclusive and will not work properly on Oculus/Rubidium. Optifine has many optimization features which, though offered as separate mods, are mostly incompatible with each other or with Rubidium/Oculus.

Patrigan commented 1 year ago

Expect Optifine to break with more mods in the future. That is not a copout answer, it is a modding community tired of Optifine. And no, Optifine does not have so many more graphical features or performance upgrades. But, I have to admit, you will not reach that with just Rubidium and Occulus.

After further investigation and the usual OptiFine brick wall where trying to fix this becomes, basically, impossible. We have an error log that does not say anything. Optifine can not be loaded in a dev environment, as they explicitly prevent that (for god knows what reason). None of our code is, indeed, special enought o actually be breaking with Optifine, so chance is high Optifine is doing some sort of "performance improvement"that is breaking something dumb. Happened before and resolved itself.

Basically, fixing this bug is not high on my priority list anymore. There is an alternative approach and I am sure for the vast majority, switching will be fine. You can check this page to see if you can find a modding community endorsed alternative for your needs: https://github.com/TheUsefulLists/UsefulMods/blob/main/Performance/Performance119.md

If after that you are still not happy, then I am terribly sorry, our mods will just not be for you. We simply do not have the time to spend on resolving an issue like this. Plenty of other bugs and missing content to tackle first. Who knows, maybe Optifine 1.20.0 will have fixed the issue again.

AlexandersFunAndGames commented 1 year ago

From what I'm aware, the fact that OptiFine shouldn't be used is something that is widely accepted in the modding community, since it alters vanilla code which is likely to mess up mods that use said code, also add that OptiFine was never even intended to be used with mods, it was always supposed to be for vanilla Minecraft only, and was only made able to be run in Forge due to so many people asking. A mod called Entity Model Features has also been released recently, which mimics OptiFine's CEM feature, this mod can run things like Fresh Animations without need for OptiFine.

Thelnfamous1 commented 1 year ago

OptiFine breaks a lot of mods and is not recommended to be used with mods, if you want shaders and better performance I recommend you use the mods Rubidium and Oculus

That's such a lame cop-out answer. Literally thousands of mods, some far more ambitious than this one, have 0 issues with any version of optifine, and then there's the odd one out like this and (until a week ago) NoCubes. For mods that are basically just adding normal objects and mobs, there's no explicable reason for it to malfunction in this way- especially when older versions of optifine don't crash it.

Also, saying "use Rubidium and Oculus" is the least helpful response. Neither of those offer even half of the graphical capabilities Optifine offers, which many resource packs depend on- not just shaders. Fresh Animations, Tooniverse, Xali's Vanilla, and Conquest, are all big name examples that need certain data optifine generates, that neither Oculus or Rubidium offer, whether you use shaders or not. There is a mod trying to add that data in, but it is currently very WIP, buggy, and mostly incompatible with other mods. Additionally, many shaders are optifine exclusive and will not work properly on Oculus/Rubidium. Optifine has many optimization features which, though offered as separate mods, are mostly incompatible with each other or with Rubidium/Oculus.

If Optifine was open-source, we would have been able to pinpoint the issue already and wouldn't be having this discussion. But because the Optifine dev is insistent on having a closed-source and also applying its code changes in an extremely mod unfriendly manner, here we are. You can tell us we're "copping out", and that other devs were able to figure out compatibility, that's not going to motivate us to mess around blindly in a black box.

Fun fact: Opening up an Optifine jar and decompiling the code on our end to diagnose the issue would also violate its copyright per the license.

FantomTchi7 commented 1 year ago

Damn, didn't expect to spark such a discussion here. First of all there's EMF which lets you use Fresh Animations without Fabric or Forge, secondly Iris got updated with support for almost all Optifine shaders, so you can access almost all of the major features without Optifine, and thirdly I don't like Optifine but it's not like we don't have ways around it at the moment, also it's not like it's that hard to fix, like I said previously previous versions worked just fine. The solution on 1.19.2 would be to just downgrade mod versions for the user, but if you're on 1.19.4 then Oculus is updated so, there won't be any issues there, but that would require a mod update to 1.19.4.

Patrigan commented 1 year ago

I think a mod update to 1.19.4 is a good idea. We can look into prioritizing that. No promises though.

FantomTchi7 commented 1 year ago

Thanks! Another solution would be to port the mod to fabric, but I suppose that would be really hard to do, and I don't think anybody would actually do that.

Thelnfamous1 commented 1 year ago

it's not like it's that hard to fix, like I said previously previous versions worked just fine

I have to make this clear: It would be easy to fix, if we were able to see what Optifine does and where that affects whatever we changed when updating the mod. We made the recent client-side changes we made, for specific reasons. To re-establish compatibility, this is what we would have to do:

1) Roll back individual changes and test each reversion with Optifine outside the dev environment 2) Once the problematic change is determined, guess how to rewrite it in a way that MIGHT work with Optifine. 3) Continually test each rewrite with Optifine outside the dev environment until it works.

I hope you can understand why continuing to get comments like "It can't be that hard to fix" is upsetting.

FantomTchi7 commented 1 year ago

Oh I didn't mean that sorry, I meant that on the user side of things as in reverting the versions.

Thelnfamous1 commented 8 months ago

Closing as won't fix