Fixes the issue with chunks not saving sometimes when unloading the world

InfernalSuite / AdvancedSlimePaper

Advanced Slime World Manager as a Paper Fork

GNU General Public License v3.0

234 stars 83 forks source link

Fixes the issue with chunks not saving sometimes when unloading the world #133

Closed TechStreetDev closed 2 weeks ago

TechStreetDev commented 2 weeks ago

Testing was done against my own plugin, I discovered this method that appeared to be commented out. Upon uncommenting this method, chunks started saving correctly again.

Tested on a 128x128 world with random blocks.

TechStreetDev commented 2 weeks ago

Most likely fixes #114 and #125

kyngs commented 2 weeks ago

Fascinating, this seems like it was commented for over a year now. I wonder why it started misbehaving now?

Since you seem to be sure that this is causing the chunk saving issues and I see no reason for this to be commented, I'm going to merge this and hope for the best.

emmanuelvlad commented 1 week ago

Does this mean there was a memory leak on SlimeChunks?