InfernalSuite / AdvancedSlimePaper

Advanced Slime World Manager as a Paper Fork
GNU General Public License v3.0
248 stars 85 forks source link

dragon fix #97

Closed BOT-Neil closed 1 month ago

BOT-Neil commented 9 months ago

It seems to work fine in slimeworlds and the normal world_the_end aswell

IllusionTheDev commented 9 months ago

Is there any reason to call the dragon fight constructor twice?

BOT-Neil commented 9 months ago

Is there any reason to call the dragon fight constructor twice?

I was thinking to force the normal dragons to spawn in world_the_end then the second call removes it on ASP so that if maybe if it fails it can only fail on ASP worlds and not fail in default bukkit code.

I'm not sure if there is a performance issue on this. All functionality seemed to work there is no longer any portals, dragon bars or fog in the ASP ends.

BOT-Neil commented 9 months ago

Maybe a better solution would be to put an else after the if(!dragonfight), and put the default bukkit code in that. I don't know lol

b0ykoe commented 1 month ago

Will close this one since we have https://github.com/InfernalSuite/AdvancedSlimePaper/pull/137