Infernus101 / KitUI

Advance AdvancedKits! Select Kits from a form, just do /kit and get kits info and select it if available! For Minecraft Bedrock Edition!
GNU General Public License v3.0
44 stars 33 forks source link

Improper SIgns Interaction #47

Closed 95CivicSi closed 6 years ago

95CivicSi commented 6 years ago

KitUI Issue

Issue description

KitUI shows up with right click on any sign that has a blank first line. ...

Reproducing the issue

  1. Create a sign.
  2. Leave the first line empty and put anything on lines 2,3, and 4.
  3. Finish creating the sign.
  4. Right click on the sign.

Client information

PocketMine-MP Version: 1.7dev-571 (50f273c0416b14eb08248a4f3bccb4ca8ab79b4d) MCPE Version: Windows 10 v1.2.8 Plugin Version: v1.1.8 (via Poggit) PHP version: 7.2

Optional information

Currently, there doesn't appear to be any documentation that shows how to properly use Signs with KitUI, however, expected behavior would be that the first or last line of a sign intended to be used with KitUI should have something unique and easily identifiable as a kit interface sign. For example, first line of a Kit sign could be [KIT].

95CivicSi commented 6 years ago

Apparently this was fixed in https://github.com/Infernus101/KitUI/commit/e71b19ffefcacef63c9fec15f1e9c7062960a97f