InfiBeyond / pe

0 stars 0 forks source link

Nonspecific error message for erronous index #3

Open InfiBeyond opened 9 months ago

InfiBeyond commented 9 months ago

image.png

The error message doesn't specify that the error in the above command is the index. This might lead to a loss of productivity as the user takes time to figure out the error in their input.

nus-se-bot commented 9 months ago

Team's Response

It literally says in the error message index must be a positive integer. Thus given the index is not even corrent in format, we dont consider it a valid input that should garner a specific response.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I fully understand the reasoning behind the rejection response. However, according to the course website, having errors messages that are correct but not specific enough can be considered a Feature Flaw.

image.png

For our particular case about invalid index error messages. The dev team did a great job in including a specific message for when the index is invalid, but this message is only shown when the inputted index is an out-of-bound positive integer.

image.png

As identified in the above bug report, in the case when the inputted index is zero or a negative number, the program does not show the invalid index-specific error message.

image.png

Instead, the generic error message for the edit command is shown. The error of the invalid index is mentioned but not specified in the error message. The user has to read through the paragraph to determine the error in the input. This can hinder the efficiency of the program as the user might not be able to identify the error easily.

Given that the issue with the invalid input error message is similar to the example given by the course guidelines under FeatureFlaw->Specificity of error message, I believe that this should be considered a FeatureFlaw bug and can be improved by the dev team in the future.