InfiBeyond / pe

0 stars 0 forks source link

Unable to have multiple appointments under the same clients. #4

Open InfiBeyond opened 9 months ago

InfiBeyond commented 9 months ago

image.png

Unable to have multiple appointments under the same clients.

This is very inconvenient if the user wants to schedule recurring or multiple meetings with a client.

nus-se-script commented 9 months ago

Team's Response

This is a design consideration made by us to not allow multiple appointments at the moment. We decided that this suggestion was a suboptimal design choice and thus bug is not in scope

Screenshot 2023-11-18 at 3.24.00 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Disallowing users to have multiple appointments is a valid Feature Flaw and should not be considered NotInScope for the following reasons:

  1. Disallowing multiple appointments under the same clients can be very inconvenient if the user wants to schedule recurring or multiple meetings with a client. By only allowing 1 appointment per client, this feature is inflexible to the user and can cause great disruption to the user. For example, the user might miss a recurring meeting that is not recorded in the system because the system cannot record it. Although this is a conscious design choice made by the dev team to lower the difficulty of implementation for other features and commands, a list can be created for appointments similar to the AddressBook without much effort as the framework for AddressBook is already implemented in the program.

image.png

Referring to the above guidelines given on the course website, this issue should be considered a FeatureFlaw and cannot be claimed as NotInScope as allowing multiple meetings under the same client can make the application reasonably useful and this feature is not hard to implement as a similar framework is already given in the AddressBook for storing clients.

  1. Furthermore, according to the course website, the bug must satisfy at least one of the 2 points in the below screenshot to be considered as NotInScope. image.png

But in the case that the application crashes when the user attempts the missing feature under normal usage (not under malicious or extreme usage) qualifies the issue as a bug. (Prof specified this under this issue in the CS2103T Forum: https://github.com/nus-cs2103-AY2324S1/forum/issues/541

For our issue, when the user attempts the missing feature to schedule multiple appointments for a client, the application crashes for certain devices. More specifically, when a user tries to schedule an appointment with a client that already has an existing appointment, the application will freeze and be unresponsive for users using MacOS full-screen mode. This bug (shown in the below screenshot) has been raised during PE and approved by the dev team.

image.png

Therefore, based on the guidelines in the course website, the behaviours of the current application, possible implementation difficulty, and the ease-of-use from an end-user pov, this issue is a FeatureFlaw and cannot be claimed as NotInscope.