Feature/CAN_XMC14002GO - Githubissues

Infineon / XMC-for-Arduino

Integration of Infineon's XMC microcontrollers into the Arduino IDE.

Other

107 stars 69 forks source link

Feature/CAN_XMC14002GO #292

Closed LinjingZhang closed 3 months ago

LinjingZhang commented 3 months ago

By creating this pull request you agree to the terms in CONTRIBUTING.md. https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md --- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description CAN library for XMC1400 2go

Related Issue

XMC Lib update
XMC1400 chip replecement

Context This PR contains mainly the CAN library of XMC4Arduino, tested on XMC1400 2go. This PR also contains some side content:

All the changes in cores/xmc_lib are just xmclib updates and don't require review.
~~Initialize Unity test framework in CAN lib.~~ (This needs to be set up after aligning with jens)
Changes in release script: Packages only the source code needed for the Arduino.
CAN setup for XMC4 Target -- not fully tested.

LinjingZhang commented 3 months ago

[x] Add CAN to build check github action workflow
[x] Commented code is indicator of WIP. It should explained (why commented) or cleanup.
[x] xmclib, we should (at least) document somewhere which version we are now using, and any differences.
[x] unity -> no sources, just which version used, where to donwload it, etc. (in future, better devops toolchain required)
[x] licenses -> company copyright, and modifications on others licensed files can be also added. Files which are not specified will be under the project overall licensing scheme.
[x] Complete metafile (library.properties) from CAN library.
[x] CAN library docs review.

LinjingZhang commented 3 months ago

Updated the missing link. fork wiki: https://github.com/LinjingZhang/XMC-for-Arduino/wiki fork release: https://github.com/LinjingZhang/XMC-for-Arduino/releases/download/V4.0.0/package_infineon_index.json

Is V4.0.0 ok? Since XMCLib has been updated

jaenrig-ifx commented 3 months ago

Updated the missing link. fork wiki: https://github.com/LinjingZhang/XMC-for-Arduino/wiki fork release: https://github.com/LinjingZhang/XMC-for-Arduino/releases/download/V4.0.0/package_infineon_index.json

Is V4.0.0 ok? Since XMCLib has been updated

Is there any user level change in the user API? Anything not backward compatible regarding usage, installation, toolchain...? I would say all these changes are a minor bump. Not major.

LinjingZhang commented 3 months ago

Updated the missing link. fork wiki: https://github.com/LinjingZhang/XMC-for-Arduino/wiki fork release: https://github.com/LinjingZhang/XMC-for-Arduino/releases/download/V4.0.0/package_infineon_index.json Is V4.0.0 ok? Since XMCLib has been updated

Is there any user level change in the user API? Anything not backward compatible regarding usage, installation, toolchain...? I would say all these changes are a minor bump. Not major.

Sure, we can use 3.2.0 in final release. Just thought of XMClib upgrading from 2.x to 4.x.

LinjingZhang commented 3 months ago

This file slipped in.

Thanks! Deleted and put in .gitignore

LinjingZhang commented 3 months ago

The size of this PR makes it difficult to review so lets run this as HIL and if this is Ok than we can release it.

Hi Olaf,

This library only have application level test (example sketch), which can be implemented in HIL. I just ran it again and made sure CAN works. The BSP was also tested before. Maybe we can release this first and then add HIL test to the workflow 😄