search

Infineon / ota-update

Other
4 stars 0 forks source link

NOTIFICATION_RESPONSE_NO_UPDATES and NOTIFICATION_RESPONSE_UPDATES are unused #2

Open campbell-brown opened 2 months ago

campbell-brown commented 2 months ago

This library seems to define NOTIFICATION_RESPONSE_NO_UPDATES and NOTIFICATION_RESPONSE_UPDATES (in cy_ota_api.h), but not use them.

Example code (e.g. the mtb-example-ota-mqtt repository) uses these values to send responses to the device.

I have run into the issue where I am sending NOTIFICATION_RESPONSE_NO_UPDATES to the device and it performs an upgrade anyway.

Are these intended to be used but not implemented yet? Or were they once used and since been removed? Or do I misunderstand how this all works?

campbell-brown commented 2 months ago

I also notice that NOTIFICATION_RESPONSE_RESULT_RECEIVED is unused: https://github.com/search?q=repo%3AInfineon%2Fota-update%20NOTIFICATION_RESPONSE_RESULT_RECEIVED&type=code

/**
 * @brief Publisher response when receiving results.
 */
#define NOTIFICATION_RESPONSE_RESULT_RECEIVED   "Result Received"

How is this intended to be used?