InfiniTimeOrg / InfiniSim

Simulator for InfiniTime user interface without needing a PineTime
GNU General Public License v3.0
164 stars 66 forks source link

Refactor notifications #80

Closed minacode closed 1 year ago

minacode commented 1 year ago

This PR patches the simulator for the notification refactoring.

NeroBurner commented 1 year ago

for the time you could also update the infinitime submodule to your branch. This should work even without changing the submodule url. Just changing the checked in commit should be enough (I don't know why, but it seems to work like this on GitHub).

minacode commented 1 year ago

Just changing the checked in commit should be enough

How can I do this? I haven't done this before and there are a lot of different explanations online that seem to do different things.

NeroBurner commented 1 year ago

if you have InfiniSim and in that folder the submodule for InfiniTime, then you just have to open your commandline in the InfiniSim folder and type

git add InfiniTime
git commit -m "WIP: update InfiniTime to Refactor Notifications PR"

The InfiniTime subfolder should be checked out at the commit of your PR with the "Refactor notifications" commit

minacode commented 1 year ago

Thank you! I hope I did it right.

The InfiniTime subfolder should be checked out at the commit of your PR with the "Refactor notifications" commit.

This was the part that confused me. I had to add my fork as remote.

NeroBurner commented 1 year ago

step by step, we all had to learn. So never be afraid to ask questions :)

minacode commented 1 year ago

Closing this because it is no longer relevant.