InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.7k stars 923 forks source link

Ability to change step goal by 500 step increments #1427

Closed calhix closed 1 year ago

calhix commented 1 year ago

Verification

Pitch us your idea!

I'd like to be able to change the step goal by 500 increments.

Description

Ideally I'd like to set the step goal to 7500. I was doing some research and saw one study stating after 7500 steps a day, the benefits tend to quickly trail down. We could also think about changing the default to 7500 but 10k is the default nearly everywhere so it's not a big deal.

Article: https://www.prevention.com/fitness/fitness-tips/a31788212/how-many-steps-should-you-walk-a-day/

minacode commented 1 year ago

Your wish for 500-steps is valid. However I doubt you are an elderly woman that wants to do no more step than necessary to increase your 4-year mortality, so don't overvalue such numbers. I think the default 10000 are still a good default.

Dheenhasty commented 1 year ago

Another way to improve this is to duplicate +/- and add +/- 1000 and +/- 100

image

i'll try to push a commit to do that :)

minacode commented 1 year ago

Honest question: do you trust the sensor enough that 100-granularity is needed for a whole day?

Dheenhasty commented 1 year ago

Of Course !!!!! :) More seriously yes i think the error margin of 100 a day could fit.

Just want to propose another solution to set up the step more easily, but the more i think of it the more i think the 500 step is ok on the watch (maybe adding a button to reset to default or static value ? )

the ideal solution could be a custom variable pushed directly thru companion app.

Riksu9000 commented 1 year ago

I don't know about increasing the granularity just to include a specific goal and making adjustment require twice the amount of presses, or clutter the UI. I doubt that 7500 is the precisely calculated perfect value, such that we must support it in particular.

calhix commented 1 year ago

I don't care so much about changing the default value of 10k but I do think making the ability to change by 500 is good. The sensor IMO is good enough for it and I don't think the average person is going to be messing with their step goal often. I do agree the UI should remain the same to reduce clutter. Especially if merging the step goal quick setting and steps app.

Riksu9000 commented 1 year ago

Can you explain why someone would want to pick 6500 steps, and 6000 would not be acceptable?

calhix commented 1 year ago

In the future if we have a goal reached notification as I brought up in #641 I'd like to know when I reached my preferred goal of 7500. Its not contingent on that issue though and there's no biggie if I go over of course but that's what I'd like my minimum steps a day to be and perhaps there are others as well.