InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.75k stars 941 forks source link

Notifications are better displayed #1431

Closed jspkay closed 1 year ago

jspkay commented 1 year ago

This is my first pull request ever, the name of the branch was supposed to be "minorUXimprovements". I basically changed the behaviour of the notification screens a little bit

minacode commented 1 year ago

This is my first pull request ever

Congrats and welcome! 😊

I basically changed the behaviour of the notification screens a little bit

Can you explain what you did and maybe also why?

jspkay commented 1 year ago

Thank you 😄 So, I received my pinetime not long ago and I've been using it since. I've noticed some problems in the experience. This request contains the fix to two problems:

minacode commented 1 year ago

Ok, so I get that your PR contains three separate changes. I recommend to also submit them as three separate PRs. They may be small, but that is a good thing. Having a discussion about all of them in one PR is not ideal.

jspkay commented 1 year ago

Oh, I get it now... It's my first time, I thought it worked the opposite way: the more changes the better. Anyways, I understand why this way is much simpler. So, what do I do? Do I remove the pr and open three different? Or what?

FintasticMan commented 1 year ago

I would say that is probably the best way to go about it. Make sure to create a different branch for each of the pull requests.

jspkay commented 1 year ago

Great thanks! I'm gonna do that