InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.7k stars 923 forks source link

WeatherService daily min/max temperature fixes #1455

Closed kieranc closed 1 year ago

kieranc commented 1 year ago

This PR fixes an issue with the WeatherService GetToday[Min:Max]Temp functions which miscalculated the timestamp of the current day end. I also made a change which makes it find all events between day start & day end (instead of only non-expired events before day end) which as far as I can see is reasonable for this function (find highest and lowest values for the current 24h period). Testing will reveal how different weather data providers set expiry time and what that means for us...