search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.69k stars 921 forks source link

Count up, change timer to red, and ring for 10s when timer completes. #1499

Open emosenkis opened 1 year ago

emosenkis commented 1 year ago

InfiniSim_2023-01-02_193840

Fixes #1374 Fresh implementation of similar features of #557

Riksu9000 commented 1 year ago

Adding the button behaviour shouldn't be too complicated and it's pretty important to avoid making the stopping of the ringing hinder usability. Also I consider the fact that the vibration doesn't stop when closing the app a bug.

I think the timed stopping of the ringing should probably be handled in the app rather than the controller, as I think it's a UI thing. You can use LVGL tasks for this. Please refer to AlarmController.cpp and Alarm.cpp for both of these issues.

emosenkis commented 1 year ago

@Riksu9000 I think I've addressed all your feedback - the button now behaves the way you asked, the app controls the ringing, leaving the app by button or by swiping should ensure that the ringing is stopped.

emosenkis commented 1 year ago

@Riksu9000 rebased and fixed

emosenkis commented 1 year ago

Ping @Riksu9000

Riksu9000 commented 1 year ago

Long pressing (the button) hasn't been addressed and there are some issues still, but I'm also reconsidering this feature in this issue https://github.com/InfiniTimeOrg/InfiniTime/issues/391#issuecomment-1383231455