InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.69k stars 921 forks source link

Enable unused parameter warning. Fix warnings. #1501

Closed Riksu9000 closed 1 year ago

Riksu9000 commented 1 year ago

Unused parameters make the code confusing and intimidating. They can also cause bugs, like in the case of MotionService. MotionService::OnNewMotionValues(x, y, z) is called before updating the values inside MotionController, but these parameters are ignored, instead using the values from MotionController, which haven't been updated yet.

DebugPins was removed, since it's not used anywhere and was causing a warning.

Include directories from other projects were marked SYSTEM, to suppress their warnings.