search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.69k stars 921 forks source link

Update workflow dependencies #1504

Closed Riksu9000 closed 1 year ago

Riksu9000 commented 1 year ago

ubuntu-latest vm has been updated from 20.04 to 22.04. To avoid sudden issues, use 22.04 explicitly. CMake doesn't need to be updated on 22.04. actions/checkout@v2 uses deprecated Node.js 12. Update to v3 which uses 16

Fixes warnings in builds. https://github.com/InfiniTimeOrg/InfiniTime/actions/runs/3811961913

FintasticMan commented 1 year ago

Now that it's using Ubuntu 22.04, we don't need to use clang-format-12 anymore, because it uses llvm 14 by default now. I suggest switching to either clang-{format,tidy} or clang-{format,tidy}-14.

In that vein, I think that llvm 12 has been out for long enough now that we can uncomment SpaceAroundPointerQualifiers in .clang-format on line 126.

Riksu9000 commented 1 year ago

I'll leave updating clang-format for another PR, as there may be new options we want to enable and it'll require discussion.