InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.69k stars 921 forks source link

Update StopWatch UI #1506

Closed Riksu9000 closed 1 year ago

Riksu9000 commented 1 year ago

Above is the new look, below is the old. Let me know if you have feedback regarding the new colors.

InfiniSim_2023-01-02_083619

InfiniSim_2023-01-02_083844

minacode commented 1 year ago

Like: the darker button background and getting rid of the green text.

Neutral: the colored buttons.

Don't like: why text instead of symbols?

ncartron commented 1 year ago

I have a slight preference for text over symbols, as it makes things a bit easier to understand / don't need to figure out what the symbols mean.

Riksu9000 commented 1 year ago

I also find that symbols look better on square buttons, but text looks better on rectangular buttons.

Elements6007 commented 1 year ago

I like the changes overall but for some reason the blue looks slightly purple to me(looks purple on device too). I think maybe a less purply blue? or maybe green? InfiniSim_2023-01-03_013329 InfiniSim_2023-01-03_015421

Riksu9000 commented 1 year ago

I've made a slight adjustment to the color to make it a bit more green.

I should mention that I want you to test these changes on your PineTime. This is because different screens can display colors in very different ways.

Please excuse the terrible image quality. From this picture you can somewhat see how my old PineTime (on the left) has much colder colors than the new one. Comparing to an sRGB monitor, I can say that the old one is too cold and the new one is very close, if not a bit warm or yellow, but both are much less saturated. smallpic

For example, #0068ff looks even better on my monitor, but doesn't look good on my old PT, so I have to use something a bit different.

minacode commented 1 year ago

Do you have a reasoning for which button you colored? Just curious because I don't know much about UI.

Riksu9000 commented 1 year ago

In this case blue is essentially "proceed", "move forward", "continue", and red is used for the destructive option. The rest are default. I experimented with coloring the lap and pause buttons as well, but I think it looks better when only red and blue are used on this screen.

Elements6007 commented 1 year ago

@Riksu9000 I tested it on my PT, i cannot really see a difference. Its probably just me, so its fine.

lman0 commented 1 year ago

the overall ui change is good to the eyes , that 's the good point!

Personally , i think the symbol are better/more resilent than text not because it's would be visually better (for rectangle it's seem not) but because when internationalization will go inside infinitime the translated word might be bigger than the button itself where as symbol remain the same whatever the language is.

it will be sad and/or confusing to change in the future the text to symbol when the not native english people will want to change text for their language

Riksu9000 commented 1 year ago

I'll think about it. There's room for 8-9 characters. Do you know of a language where the translations would not fit? It could still take a long time for translations to get implemented, so having this in the meantime is probably not an issue, and we would most likely need to change some screens anyway.

lman0 commented 1 year ago

french for instance , would not fit in some case (start mean in french either "commencer" /"demarrer"/"depart" some would use "depart ", but then resume is only translatable in " reprendre") i think some language like deutch , maybe be longer the same for nordic langage arabic , albei may be able to remain inside , but the button would need to be bigger to be readable

minacode commented 1 year ago

German would be ok: Start, Stop, Pause, Weiter, Runde

Less things to translate would still be a good though.

NeroBurner commented 1 year ago

I like the color and design changes. But I'm in favor of keeping symbols instead of words. Symbols don't need to be translated

Riksu9000 commented 1 year ago

While text on wide buttons isn't something written in the ui guidelines, it's something I've had in mind for a while, and I'd rather avoid compromising the design. Therefore we can either make an exception because of designing for a small screen, or try to redesign the screen. I'll be looking into the options.

Riksu9000 commented 1 year ago

Closing in favor of #1561