search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.68k stars 916 forks source link

Improve SetDate and SetTime UI #1533

Open Elements6007 opened 1 year ago

Elements6007 commented 1 year ago

Widens the 'set' button to the length of the counter widgets and adds the use of the InfiniTimeTheme in SettingSetDate

InfiniSim_2023-01-15_041650

kieranc commented 1 year ago

Looks good, is there a way to make the selectors the same size between the 2 screens?

Elements6007 commented 1 year ago

Looks good, is there a way to make the selectors the same size between the 2 screens?

Well if jetbrains_mono_42 is changed to jetbrains_mono_bold_20, which is the same as in SettingSetDate then they will be the same size. Although it definitely looks more uniform, i think the larger counters look better. InfiniSim_2023-01-16_163511

Riksu9000 commented 1 year ago

Why not make them different sizes on each screen?

Elements6007 commented 1 year ago

Why not make them different sizes on each screen?

could you elaborate plz?

github-actions[bot] commented 1 year ago
Build size and comparison to main: Section Size Difference
text 406504B 0B
data 940B 0B
bss 53568B 0B
Riksu9000 commented 1 year ago

I mean the buttons on the different screens. They don't need to be the exact same width. Being aligned with the visible counters is more important I think.

Riksu9000 commented 1 year ago

The button size is not correct on the SettingSetDate screen.

Elements6007 commented 1 year ago

The height? It is 50 because that is what it should be, you said it would be ok to change it.

You could. You don't have to.

unless I misunderstood.

Riksu9000 commented 1 year ago

The width.

image

Elements6007 commented 1 year ago

Ah ok, I never checked down to that small. It should be fixed now. infiniui2 (Custom) (left side) infiniui (Custom) (right)