build-size-workflow: Fix when base gets updated

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS

GNU General Public License v3.0

2.68k stars 916 forks source link

build-size-workflow: Fix when base gets updated #1567

Closed Riksu9000 closed 1 year ago

Riksu9000 commented 1 year ago

The github.event.pull_request.base.sha in the workflow doesn't get updated when there are new commits in the base branch. Instead always checkout the branch to check the sha manually and cache only the build.

The ownership fix seems to still be necessary

Riksu9000 commented 1 year ago

It's comparing to older develop, causing incorrect results.

JF002 commented 1 year ago

Oh yes, I see... This could be confusing, indeed!