search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.68k stars 916 forks source link

motion: Disable Motion app #1603

Closed Riksu9000 closed 1 year ago

Riksu9000 commented 1 year ago

This is a debugging app, not useful for most people. Also remove the app icon.

github-actions[bot] commented 1 year ago
Build size and comparison to develop: Section Size Difference
text 407168B -5912B
data 940B 0B
bss 53568B -8B
JF002 commented 1 year ago

Oh wow! 6KB for this app? What's using all this space? The graph widget from LVGL, maybe?

Riksu9000 commented 1 year ago

It must be the chart widget. LVGL things always seem like candidates for memory savings to me.

JF002 commented 1 year ago

Interesting! Most of the time, I do not like removing features from the firmware but... this one makes sense : the memory usage for this test/debug app is not reasonable.

I'm wondering : should we provide another (simpler) test app for the motion sensor?

Riksu9000 commented 1 year ago

I don't think removing features is a bad idea if it will improve the polish of the firmware, which removing a debug app from release firmware definitely does. I don't think a test app needs to be added, as the detected accelerometer in SystemInfo seems to usually be ??? when the accelerometer is not working #1099.

LinuxinaBit commented 1 year ago

Possibly just a live updating readout of the raw accelerometer X, Y, and Z values in Settings (and Steps too, I guess) could serve the same purpose.

JF002 commented 1 year ago

I don't think a test app needs to be added, as the detected accelerometer in SystemInfo seems to usually be ??? when the accelerometer is not working.

Fair enough !

Possibly just a live updating readout of the raw accelerometer X, Y, and Z values in Settings (and Steps too, I guess) could serve the same purpose.

Yes, it could, but it won't bring any other value than checking that the sensors returns some values. As Riksu said, we can check that the motion sensor is detected in SystemInfo so we probably don't need another app for that purpose.